fix: address various check/test/CI issues #2441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… will actually work as expected)
…es logic will actually work as expected)" This reverts commit 01e73fb.
cpsievert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some new GHA,
R CMD check, roxygen, and testthat issues.Also updates visual tests to match what you'd get with the current CRAN version of ggplot2 (v3.5.2).
NOTE: I'm not exactly sure what caused the difference in stroke in the sf baselines, but 01e73fb will fix the (unwanted) difference with the latest ggplot2 (coming in a follow up PR)